Set CLANG_ENABLE_MODULES to YES when generating projects #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this was kept intentionally off because we have non-modular includes in swiftpm packages and it caused issues with autocompletion when a clang module is present. Can you check if autocomplete still works (in packages with Clang and Swift targets) after turning this on? |
|
@keith any updates? |
|
I haven't had a chance to check this yet. If anyone has a chance to try and get a project that fails for this issue that'd be awesome! Otherwise I will try to soon |
|
I just checked this and autocomplete still falls over if this setting turned on. #1406 seems like a better solution but needs verification. |
|
I'll close this one then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.